Skip to content

[Feature][rest-api] Add whether master node identifier #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hailin0 merged 2 commits into from
Sep 11, 2024
Merged

[Feature][rest-api] Add whether master node identifier #7603

hailin0 merged 2 commits into from
Sep 11, 2024

Conversation

@liugddx
Copy link
Member

@liugddx liugddx commented Sep 8, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the Zeta label Sep 8, 2024
Hisoka-X
Hisoka-X reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case.

@Hisoka-X Hisoka-X changed the title (feature)[rest-api] Add whether master node identifier [feature][rest-api] Add whether master node identifier Sep 10, 2024
@github-actions github-actions bot added the e2e label Sep 10, 2024
@Hisoka-X Hisoka-X changed the title [feature][rest-api] Add whether master node identifier [Feature][rest-api] Add whether master node identifier Sep 11, 2024
@hailin0 hailin0 merged commit 9ba94b6 into apache:dev Sep 11, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 11, 2024

@liugddx Shall we update doc too? https://seatunnel.apache.org/docs/seatunnel-engine/rest-api#returns-system-monitoring-information

@liugddx
Copy link
Member Author

liugddx commented Sep 12, 2024

@liugddx Shall we update doc too? https://seatunnel.apache.org/docs/seatunnel-engine/rest-api#returns-system-monitoring-information

Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved e2e reviewed Zeta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liugddx @Hisoka-X @hailin0