[Feature][Zeta] add rest api to update node tags #7542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please enable your repo's action |
liunaijie
reviewed
Sep 2, 2024
|
|
||
| @Override | ||
| public CompletableFuture<Void> releaseWorker(String workerID) { | ||
| public CompletableFuture<Void> releaseWorker(String workerId) { |
Member
There was a problem hiding this comment.
please do not update this as not use in this pr
|
|
||
| @Override | ||
| public CompletableFuture<Void> releaseWorker(String workerID) { | ||
| public CompletableFuture<Void> releaseWorker(String workerId) { |
|
|
||
| List<SlotProfile> getAssignedSlots(Map<String, String> tags); | ||
|
|
||
| void registerWorker(Address address,WorkerProfile workerProfile); |
| NodeEngineImpl nodeEngine = seaTunnelServer.getNodeEngine(); | ||
| MemberImpl localMember = nodeEngine.getLocalMember(); | ||
| if (!params.isEmpty() && params.containsKey("tags")) { | ||
| localMember.updateAttribute((Map<String, String>) params.get("tags")); |
Member
There was a problem hiding this comment.
if this tags value is not a Map<String, String>, what's the response?
and if not tags is null or empty, is this will clear the node tags?
Hisoka-X
reviewed
Sep 4, 2024
| } | ||
|
|
||
| @Test | ||
| public void testUpdateTags() { |
Member
There was a problem hiding this comment.
Please add a test case for update tag failed.
Member
|
LGTM if ci pass |
liunaijie
approved these changes
Sep 6, 2024
Hisoka-X
approved these changes
Sep 6, 2024
Member
|
Hi @Cheun99 , how about add a link into to tell user we can update node tags when use resource isolation feature? |
4 tasks
Contributor
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
new feature #7510
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.