[Feature][Core] Add event notify for all connector #7501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangshenghang
changed the title
Hisoka-X
reviewed
Aug 27, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
Thanks @zhangshenghang ! Overall LGTM. I left some minior problem.
...nel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java
Outdated
Show resolved
Hide resolved
...nel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java
Show resolved
Hide resolved
...ine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SinkFlowLifeCycle.java
Outdated
Show resolved
Hide resolved
Hisoka-X
changed the title
Hisoka-X
approved these changes
Aug 28, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM if ci passes. Thanks @zhangshenghang
wuchunfu
approved these changes
Aug 28, 2024
Member
wuchunfu
left a comment
wuchunfu
left a comment
There was a problem hiding this comment.
LGTM, thanks @zhangshenghang
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
* [feature]add event notify * [feature]add event notify * [fixbug]fix some problem * [feature]fix some problem * [feature]fix some problem
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Aug 29, 2024
* [feature]add event notify * [feature]add event notify * [fixbug]fix some problem * [feature]fix some problem * [feature]fix some problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
@Hisoka-X
1. Source-related Classes
2. Enumerator-related Classes
3. Sink-related Classes
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.