[Feature][Core] Support cdc task ddl restore for zeta #7463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-merge-ddl
branch
2 times, most recently
from
23d99f9 to
9d7d79f
Compare
Hisoka-X
reviewed
Aug 24, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
It seem lack test case. Shall we add some?
For example, read updated/deleted column data to unsupported transform/sink, what's will happen?
And read table -> savepoint -> update column -> restore? I think the change will solve the problem of this scenario. But we need test case.
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SinkWriter.java
Show resolved
Hide resolved
...api/src/main/java/org/apache/seatunnel/api/table/factory/ChangeStreamTableSourceFactory.java
Show resolved
Hide resolved
dailai
reviewed
Aug 26, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SupportSchemaEvolutionSinkWriter.java
Show resolved
Hide resolved
dailai
reviewed
Aug 26, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSink.java
Show resolved
Hide resolved
3 tasks
Member
Author
Added |
Member
|
@hailin0 hi, I think this part needs a design to help me understand the whole process |
hailin0
force-pushed
the
dev-merge-ddl
branch
2 times, most recently
from
2a26cea to
1bf5812
Compare
3 tasks
3 tasks
hailin0
force-pushed
the
dev-merge-ddl
branch
2 times, most recently
from
550ff5f to
fbb5e10
Compare
hailin0
force-pushed
the
dev-merge-ddl
branch
from
fbb5e10 to
262b77b
Compare
hailin0
force-pushed
the
dev-merge-ddl
branch
from
262b77b to
32e3bae
Compare
hailin0
force-pushed
the
dev-merge-ddl
branch
5 times, most recently
from
af42692 to
5ae5961
Compare
hailin0
force-pushed
the
dev-merge-ddl
branch
from
5ae5961 to
fc72bf6
Compare
hailin0
changed the title
Contributor
hailin0
force-pushed
the
dev-merge-ddl
branch
from
e5e63b8 to
125c091
Compare
hailin0
force-pushed
the
dev-merge-ddl
branch
9 times, most recently
from
a806552 to
9c0828a
Compare
hailin0
commented
Nov 12, 2024
...src/main/java/org/apache/seatunnel/connectors/cdc/debezium/ConnectTableChangeSerializer.java
Show resolved
Hide resolved
hailin0
force-pushed
the
dev-merge-ddl
branch
from
9c0828a to
7148620
Compare
Hisoka-X
reviewed
Nov 13, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/TableSchema.java
Show resolved
Hide resolved
dailai
approved these changes
Nov 13, 2024
Member
He is great |
Hisoka-X
approved these changes
Nov 14, 2024
4 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Improve][CDC] Improve cdc task state restore for zeta
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added
https://github.com/apache/seatunnel/pull/7463/files#diff-56c06c7dde242a3733bec78c1d71f5a32baa3530be2c8f336e28de7e390312a8
Check list
New License Guide
release-note.