[Improve] Skip downloading transitive dependency when install plugins #7374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @kevinjmh ! Could you follow the guide to open github action on your fork repository? https://github.com/apache/seatunnel/pull/7374/checks?check_run_id=28636510415 |
Member
Author
|
ok, it is opened now |
Member
|
Try push an emtpy commit to trigger it. |
kevinjmh
force-pushed
the
skipTransitiveDeps
branch
from
2782f78 to
121a14d
Compare
Member
|
I noticed we're missing a test for the download script, would you be willing to add one in https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-e2e-common/src/test? Thanks. |
Hisoka-X
approved these changes
Aug 21, 2024
hailin0
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Skip downloading transitive dependency when install plugins to improve user experience
Does this PR introduce any user-facing change?
No
How was this patch tested?
Fresh new install local test.
Check list
New License Guide
release-note.Before:
After:
