Skip to content

Conversation

@XenosK
Copy link
Contributor

@XenosK XenosK commented Aug 8, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@XenosK
Copy link
Contributor Author

XenosK commented Aug 8, 2024

This Pr For Sls(Aliyun Log Service) Source Connector

@Hisoka-X Hisoka-X added the First-time contributor First-time contributor label Aug 8, 2024
@XenosK
Copy link
Contributor Author

XenosK commented Aug 9, 2024

1、2、4、5 already done,next , add e2e testcase

@github-actions github-actions bot added the e2e label Aug 9, 2024
@XenosK
Copy link
Contributor Author

XenosK commented Aug 9, 2024

I have successfully run the test case locally, but need a personal account to run it

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 9, 2024

I have successfully run the test case locally, but need a personal account to run it

Commit the code and disable the test case, then provide a screenshot of the successful test.

@XenosK
Copy link
Contributor Author

XenosK commented Aug 9, 2024

I have successfully run the test case locally, but need a personal account to run it

Commit the code and disable the test case, then provide a screenshot of the successful test.

testcase_sls

@XenosK
Copy link
Contributor Author

XenosK commented Aug 10, 2024

cc @Hisoka-X A screenshot of the successful test and Is it as indicated in the screenshot to disable the test case

@Hisoka-X
Copy link
Member

Please fix ci.

@XenosK
Copy link
Contributor Author

XenosK commented Aug 12, 2024

Please fix ci.

Fixed

@Hisoka-X
Copy link
Member

@XenosK
Copy link
Contributor Author

XenosK commented Aug 13, 2024

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes

@Hisoka-X
Copy link
Member

Thanks @XenosK !

@hailin0 hailin0 merged commit 527c7c7 into apache:dev Aug 13, 2024
@XenosK XenosK deleted the dev branch August 29, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants