Skip to content

Conversation

@corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Aug 7, 2024

Purpose of this pull request

issue : #7331

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the Zeta label Aug 7, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 8, 2024

cc @hawk9821

@Hisoka-X Hisoka-X linked an issue Aug 8, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the http api return new metrics too. And add test case in

@corgy-w
Copy link
Contributor Author

corgy-w commented Aug 8, 2024

Please make sure the http api return new metrics too. And add test case in

get

@corgy-w
Copy link
Contributor Author

corgy-w commented Aug 9, 2024

PTAL @Hisoka-X @hawk9821 When testing, found that the rate-related metrics could not be aggregated with full precision equality, so need to pay attention to this point.

@corgy-w corgy-w requested a review from Hisoka-X August 12, 2024 02:53
@corgy-w corgy-w requested a review from Hisoka-X August 12, 2024 08:47
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minior problem.

import java.util.stream.StreamSupport;

import static com.hazelcast.internal.ascii.rest.HttpStatusCode.SC_500;
import static org.apache.seatunnel.api.common.metrics.MetricNames.SINK_WRITE_BYTES;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @liugddx better take a look.

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Wait for CI to pass

@liugddx liugddx merged commit 16c5065 into apache:dev Aug 14, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 11, 2025
* [Feature][Zeta] Added other metrics info of multi-table

* [Feature][Zeta] Added other metrics restApi

* [Feature][Zeta] Added other metrics restApi test

* [Feature][Zeta] update rest-api doc

* [Improve][Connector-V2] optimize code

* [Improve][Connector-V2] optimize code

---------

Co-authored-by: wangchao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Zeta] Added other metrics info of multi-table

3 participants