[Fix][Connector-V2][Elasticsearch]Fix sink configuration for DROP_DATA #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @chl-wxp as well. |
Member
|
Thanks @Wudadada for created this PR! Could you follow the guide to open github action on your fork repository? https://github.com/apache/seatunnel/pull/7124/checks?check_run_id=27141444120 |
Member
|
cc @hailin0 as well. |
Member
|
Could you add a test case in to make sure all data are be deleted? |
Contributor
Author
Thanks for pointing out the issues! I encountered a problem in #7140 that is preventing me from debugging, and I am trying to solve the situation. |
Hisoka-X
approved these changes
Jul 9, 2024
hailin0
approved these changes
Jul 9, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 10, 2024
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 13, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
According to the documentation, the logic for DROP_DATA is to preserve the database structure and delete the data. The original implementation deleted the entire index and recreated it, which caused some field types and parameters to change. This PR corrects the implementation to use the Elasticsearch command to clear index data while preserving the index structure:
POST /your_index_name/_delete_by_query { "query": { "match_all": {} } }Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the connector-elasticsearch-e2e and my local es seatunnel task.
Check list
New License Guide
release-note.