Skip to content

Conversation

@Asura7969
Copy link
Contributor

Purpose of this pull request

close #6901
ref #7113

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Hisoka-X
Hisoka-X previously approved these changes Jul 7, 2024
delete.setTableId(tableId);
collector.collect(delete);
} else {
} else if (operation == Envelope.Operation.UPDATE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to update related statements, are there any other statements that can reach the else block?

Copy link
Contributor Author

@Asura7969 Asura7969 Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRUNCATE or MESSAGE
Can we ignore these two operations? then like:

 else {
      log.warn("Received {} operation, skip", operation);
  }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should ignore it. cc @hailin0

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit ae81879 into apache:dev Jul 8, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 10, 2024
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 13, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postgreCDC TO hive

3 participants