Skip to content

Conversation

@zhangshenghang
Copy link
Member

Purpose of this pull request

In some scenarios, you need to set the TTL time

How was this patch tested?

Local and server deployment operation

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this new config key into doc

.withDescription("Hbase extra config");

public static final Option<Long> HBASE_TTL_CONFIG =
Options.key("ttl").longType().defaultValue(-1L).withDescription("Hbase ttl config");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Options.key("ttl").longType().defaultValue(-1L).withDescription("Hbase ttl config");
Options.key("ttl").longType().defaultValue(-1L).withDescription("The expiration time configuration for writing hbase data. The default value is -1, indicating no expiration time.");

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your guidance. The modifications have been completed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7116 (review)

Add Complete

@hailin0 hailin0 merged commit adafd80 into apache:dev Jul 6, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 10, 2024
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 13, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@zhangshenghang zhangshenghang deleted the feature-support-hbase-sink-ttl branch September 6, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants