Skip to content

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Jun 4, 2024

Purpose of this pull request

This PR try to do two things:

  1. Fix mysql create index with blob series field type. We should add index size when create index. Please refer https://stackoverflow.com/questions/1827063/mysql-error-key-specification-without-a-key-length
  2. We should do some clean when get primary/constraint keys name. Because the upstream may be a different database, sometimes these names may contain strange characters. We need to clean these characters to ensure that the downstream can create corresponding indexes as much as possible.

Does this PR introduce any user-facing change?

Yes, the index name changed sometimes. But I think it's not a big deal.

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X changed the title [Improve] Clean key name in catalog table [Improve][Connector-V2] Clean key name in catalog table Jun 4, 2024
@hailin0 hailin0 merged commit a399ef4 into apache:dev Jun 14, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants