Skip to content

[Fix][Transform] Fix sql transform lose source type and options #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Carl-Zhou-CN merged 1 commit into from
May 21, 2024
Merged

[Fix][Transform] Fix sql transform lose source type and options #6855

Carl-Zhou-CN merged 1 commit into from
May 21, 2024

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented May 15, 2024

Purpose of this pull request

This PR fix sql transform lose source type and options.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X
Copy link
Member Author

Hisoka-X commented May 15, 2024

cc @hailin0 @rewerma

Carl-Zhou-CN
Carl-Zhou-CN approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit afdcb32 into apache:dev May 21, 2024
@luhanbin111
Copy link

luhanbin111 commented Jul 17, 2024

?修复了什么，我使用mongodb同步mysql时还是会显示没有配置result_table_name
2024-07-17 16:32:40,417 INFO [o.a.s.e.c.p. ConfigParserUtil ] [main] - Currently, incorrect configuration of source_table_name and result_table_name options don't affect job running. In the future we will ban incorrect configurations.
2024-07-17 16:32:40,417 WARN [o.a.s.e.c.p. ConfigParserUtil ] [main] - This configuration is not recommended. A source/transform(MongoDB-CDC) is not configured with 'result_table_name' option, but subsequent transform/sink(Sql) is configured with 'source_table_name' option value of 'test'.
2024-07-17 16:32:40,417 INFO [o.a.s.e.c.p. ConfigParserUtil ] [main] - Currently, incorrect configuration of source_table_name and result_table_name options don't affect job running. In the future we will ban incorrect configurations.
2024-07-17 16:32:40,417 WARN [o.a.s.e.c.p. ConfigParserUtil ] [main] - This configuration is not recommended. A source/transform(Sql) is configured with 'result_table_name' option value of 'test1', but subsequent transform/sink(jdbc) is not configured with 'source_table_name' option.

@liuyhl
Copy link

liuyhl commented Jul 29, 2024

同问

chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@Hisoka-X
[Fix][Transform] Fix sql transform lose source type and options (apac…
e4e6182 
…he#6855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

+1 more reviewer

@lightzhao lightzhao lightzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved bugfix reviewed SQL Transform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hisoka-X @luhanbin111 @liuyhl @hailin0 @lightzhao @Carl-Zhou-CN