Skip to content

Conversation

@JohnZp
Copy link
Contributor

@JohnZp JohnZp commented May 9, 2024

Purpose of this pull request

Some config loading log don't take effect about log4j2
When we startup a command like seatunnel.sh -l, the log as follows.

image

Generally, if you execute commands through some programs, such non-standard logs will be captured in the error log stream, which is very bad

Does this PR introduce any user-facing

image

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented May 10, 2024

Thanks @JohnZp for created this PR!
Could you provide a demo of after optimized?
ignore it.


if exist "%CONF_DIR%\log4j2.properties" (
set "JAVA_OPTS=%JAVA_OPTS% -Dlog4j2.configurationFile=%CONF_DIR%\log4j2.properties"
set "JAVA_OPTS=%JAVA_OPTS% -Dhazelcast.logging.type=log4j2 -Dlog4j2.configurationFile=%CONF_DIR%\log4j2.properties"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late, this is a good pr

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 4cefb57 into apache:dev May 15, 2024
@hailin0
Copy link
Member

hailin0 commented May 15, 2024

LGTM

chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants