[Fix][Jdbc Connector]: Fix JdbcCatalogOptions BASE builder will be changed by call required()
#6788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged by call `required()` JdbcCatalogOptions BASE builder will be changed by call `required()` because it just a static variable and Builder inner list will be changed if you are using code like this: ```java OceanBaseCatalogFactory factory = new OceanBaseCatalogFactory(); factory.optionRule(); factory.optionRule(); ``` So change the BASE variable to a function, when we call the `base()` function, it will create a new Builder, so it will be new every call;
Member
|
Hi @Jetiaime , thanks for open this PR! Please follow the guide to open CI on your fork repository. https://github.com/apache/seatunnel/pull/6788/checks?check_run_id=24501297956 |
Member
|
Overall LGTM |
4 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
JdbcCatalogOptions BASE builder will be changed by call
required()because it just a static variable and Builder inner list will be changed if you are using code like this:So change the BASE variable to a function, when we call the
base()function, it will create a new Builder, so it will be new every call;Does this PR introduce any user-facing change?
No.
How was this patch tested?
Check list
New License Guide
release-note.