Skip to content

Conversation

@Jetiaime
Copy link
Contributor

@Jetiaime Jetiaime commented May 2, 2024

Purpose of this pull request

Fix KuduCatalogFactory.optionRule() will throw an Exception because conditional OptionRule should be in the optinal or required options.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Covered By the Tests

Check list

…ow an Exception

Fix `KuduCatalogFactory.optionRule()` will throw an Exception because conditional OptionRule should be in the optinal or required options.
@Carl-Zhou-CN
Copy link
Member

@Jetiaime hi, Follow these steps to resolve the error
image

@Carl-Zhou-CN Carl-Zhou-CN added the First-time contributor First-time contributor label May 6, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented May 6, 2024

same as #6788 (comment)

@Hisoka-X
Copy link
Member

Hisoka-X commented May 6, 2024

@Jetiaime
Copy link
Contributor Author

Jetiaime commented May 6, 2024

Could you add test case like

?

thx, test has been added.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed.

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit 45a4e15 into apache:dev May 6, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
…hrow an Exception (apache#6787)

* fix(KuduCatalogFactory): Fix KuduCatalogFactory.optionRule() will throw an Exception

Fix `KuduCatalogFactory.optionRule()` will throw an Exception because conditional OptionRule should be in the optinal or required options.

* [Feat][KuduFactoryTest]: Add a Test On KuduFactory

1. Add a Test On KuduFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants