[bigfix][S3 File]:Change the [SCHEMA] attribute of the [S3CONF class] to be non-static to avoid being reassigned after deserialization #6717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be non-static to avoid being reassigned after deserialization
EricJoy2048
reviewed
Apr 16, 2024
| Config config = readonlyConfig.toConfig(); | ||
| HadoopConf hadoopConf = new S3Conf(readonlyConfig.get(S3ConfigOptions.S3_BUCKET)); | ||
| String bucketName = readonlyConfig.get(S3ConfigOptions.S3_BUCKET); | ||
| String bucketName = config.getString(S3ConfigOptions.S3_BUCKET.key()); |
Member
There was a problem hiding this comment.
Can reuse the code above:
return buildWithReadOnlyConfig(readonlyConfig.toConfig);
… to be non-static to avoid being reassigned after deserialization
EricJoy2048
approved these changes
Apr 16, 2024
Member
EricJoy2048
left a comment
EricJoy2048
left a comment
There was a problem hiding this comment.
LGTM, waiting for CI complete.
hailin0
approved these changes
Apr 17, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
… to be non-static to avoid being reassigned after deserialization (apache#6717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
fix bug : #6678
The [S3Conf] class in the S3 connector has a statically modified variable [SCHEMA], which causes it to be reassigned after deserialization. I will remove the static modification:
close #6678
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note.