[fix] fix get seatunnel row size npe issue #6681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Apr 11, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM except one minior problem.
Comment on lines
55
to
58
| new Integer[] {1, 2, 3}, | ||
| new Long[] {1L, 2L, 3L}, | ||
| new Double[] {1D, 2D}, | ||
| new Float[] {1F, 2F} |
Member
There was a problem hiding this comment.
You missed Boolean[], Byte[], Short[],
hailin0
approved these changes
Apr 11, 2024
lostinwind
added a commit
to lostinwind/dataGovernance
that referenced
this pull request
Apr 12, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #6455
Does this PR introduce any user-facing change?
How was this patch tested?
update the current ut
Check list
New License Guide
release-note.