Skip to content

Conversation

@L-Gryps
Copy link
Contributor

@L-Gryps L-Gryps commented Mar 22, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@L-Gryps L-Gryps changed the title Feat xugudb connector [feature][connector-v2] add xugudb connector Mar 25, 2024
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case XUGU_VARCHAR:
case XUGU_VARCHAR2:
builder.dataType(BasicType.STRING_TYPE);
builder.columnLength(typeDefine.getLength());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this length is char length or byte length ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is char length

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because multi-byte characters are handled differently in various databases, the byte length is uniformly used in seatunnel

use TypeDefineUtils.charTo4ByteLength(your length)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have handled it in XuguTypeMapper

@@ -0,0 +1,48 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename jdbc_xugu_source_and_upset_sink.conf to jdbc_xugu_source_and_upsert_sink.conf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hailin0 hailin0 added this to the 2.3.5 milestone Mar 29, 2024

@Slf4j
@AutoService(TypeConverter.class)
public class XuguTypeConverter implements TypeConverter<BasicTypeDefine> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@Slf4j
@AutoService(TypeConverter.class)
public class XuguTypeConverter implements TypeConverter<BasicTypeDefine> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null,
null,
null,
null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool field is null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,The Boolean data type has three states: true, false, and unknown. Field values can be true, false, null

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X requested a review from TyrantLucifer April 2, 2024 05:58
@EricJoy2048 EricJoy2048 merged commit 80f392a into apache:dev Apr 2, 2024
@L-Gryps L-Gryps deleted the feat-xugudb-connector branch April 2, 2024 09:26
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants