Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

This PR fix the behavior of thread context classloader be set to null when job done or submit job done. If other thread is using this classloader for load class, it may not be able to find an available classloader (because it thread context classloader be set to null). So we should ensure that the number of references to the classloader is 0 before trying to clean up the classloader in the thread.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X linked an issue Mar 14, 2024 that may be closed by this pull request
3 tasks
@Hisoka-X
Copy link
Member Author

cc @W-dragan @liugddx

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit d580860 into apache:dev Mar 15, 2024
@Hisoka-X Hisoka-X deleted the fix-classloader-released-not-right-time branch March 15, 2024 06:56
LeonYoah pushed a commit to LeonYoah/seatunnel that referenced this pull request May 8, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [HTTP SUBMIT JOB] Error reported when submitting tasks concurrently

3 participants