Skip to content

Conversation

@liunaijie
Copy link
Member

Purpose of this pull request

improve the rest api. when get job status by job id. always return the job id to response.

Does this PR introduce any user-facing change?

How was this patch tested?

no need

Check list

@liunaijie liunaijie force-pushed the restapi-getrunningjob branch from f13d2c3 to 0729bbf Compare February 29, 2024 06:52
@liunaijie
Copy link
Member Author

@liugddx PTAL

EricJoy2048
EricJoy2048 previously approved these changes Mar 4, 2024
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a UT case.

@liunaijie liunaijie force-pushed the restapi-getrunningjob branch from 81c2f33 to 771ebcf Compare March 6, 2024 05:03
@liunaijie
Copy link
Member Author

Please add a UT case.

Done, PTAL, thx

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hailin0 hailin0 merged commit 78cb0de into apache:dev Mar 6, 2024
@liunaijie liunaijie deleted the restapi-getrunningjob branch March 8, 2024 03:42
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants