Skip to content

Conversation

@liunaijie
Copy link
Member

Purpose of this pull request

add logo

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@EricJoy2048
Copy link
Member

Hi, Can you explain in detail what problem this PR wants to solve?

@liunaijie
Copy link
Member Author

Hi, Can you explain in detail what problem this PR wants to solve?

No, this is not to solve any problem, just want add an icon to IDEA for funny.
after this, when you open the project you can see the icon instead of the S word.

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, it works

@hailin0 hailin0 changed the title add icon Display project icon in idea Mar 11, 2024
@hailin0
Copy link
Member

hailin0 commented Mar 11, 2024

LGTM

@Hisoka-X Hisoka-X merged commit 27d971a into apache:dev Mar 11, 2024
@liunaijie liunaijie deleted the idea_icon branch March 15, 2024 05:26
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants