[Feature] Support nanosecond in Doris DateTimeV2 type #6358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
commented
Feb 23, 2024
Comment on lines
287
to
+288
| GenerateTestData.genString(12), | ||
| GenerateTestData.genDatetimeString(false), | ||
| GenerateTestData.genDatetimeString(true), | ||
| GenerateTestData.genDatetimeString(false), |
Member
Author
There was a problem hiding this comment.
Before this PR, the data of generated not match with field order, so the datetime with nano field always insert datetime without nano. So this pr correct it to make sure test work fine.
EricJoy2048
approved these changes
Mar 4, 2024
hailin0
approved these changes
Mar 6, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR supported Doris write datetime with nanosecond.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.