Skip to content

Conversation

@hailin0
Copy link
Member

@hailin0 hailin0 commented Jan 15, 2024

Purpose of this pull request

[Oracle-CDC] Support custom table primary key
link #6106

Does this PR introduce any user-facing change?

Add new config key

How was this patch tested?

Added

Check list

@hailin0 hailin0 force-pushed the dev-support-cdc-custom-primarykey branch from 853594f to 2f755cf Compare January 16, 2024 03:11
}

@TestTemplate
public void testOracleCdcCheckDataWithCustomPrimaryKey(TestContainer container)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this e2e is passed
image

@hailin0 hailin0 marked this pull request as ready for review January 16, 2024 13:47
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will make this end-to-end (E2E) stable in the future

@hailin0 hailin0 merged commit ae4240c into apache:dev Jan 17, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants