[Hotfix][Zeta] Fix zeta scheduler bug #6050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricJoy2048
force-pushed
the
163_fix_zeta_scheduler_bug
branch
from
4337977 to
13d03a0
Compare
hailin0
reviewed
Dec 22, 2023
...nel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/SubPlan.java
Outdated
Show resolved
Hide resolved
...nector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/SeaTunnelSlotIT.java
Outdated
Show resolved
Hide resolved
…e/src/test/java/org/apache/seatunnel/engine/e2e/SeaTunnelSlotIT.java Co-authored-by: hailin0 <[email protected]>
Hisoka-X
reviewed
Dec 23, 2023
...nel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/SubPlan.java
Show resolved
Hide resolved
EricJoy2048
force-pushed
the
163_fix_zeta_scheduler_bug
branch
from
284323c to
499f464
Compare
Hisoka-X
reviewed
Dec 23, 2023
...nel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/SubPlan.java
Show resolved
Hide resolved
Hisoka-X
reviewed
Dec 23, 2023
Comment on lines
-120
to
-123
| if (StringUtils.isNotEmpty(jobResult.getError()) | ||
| || jobResult.getStatus().equals(JobStatus.FAILED)) { | ||
| throw new SeaTunnelEngineException(jobResult.getError()); | ||
| } |
Member
There was a problem hiding this comment.
If client never throw exception even job failed. The shell status code always return 0, does not meet shell standards. Also client side will not get job result error msg. We need test case to cover it.
Member
Author
There was a problem hiding this comment.
If client never throw exception even job failed. The shell status code always return 0, does not meet shell standards. Also client side will not get job result error msg. We need test case to cover it.
Done, I have added test cases.
…che/seatunnel/engine/server/dag/physical/SubPlan.java Co-authored-by: Jia Fan <[email protected]>
EricJoy2048
force-pushed
the
163_fix_zeta_scheduler_bug
branch
from
754f56f to
f246365
Compare
Hisoka-X
approved these changes
Dec 26, 2023
hailin0
approved these changes
Dec 26, 2023
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Already add test case.
Check list
New License Guide
release-note.