Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

This PR fix SaveModeHandler interface not be closed after execute handleSaveMode.

Does this PR introduce any user-facing change?

no

How was this patch tested?

I will add test case later.

Check list

@hailin0
Copy link
Member

hailin0 commented Nov 14, 2023

LGTM

waiting for ci ok

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Nov 14, 2023
@Hisoka-X
Copy link
Member Author

cc @hailin0 @ruanwenjun CI passed.

@Hisoka-X Hisoka-X added the bug label Nov 24, 2023
@EricJoy2048 EricJoy2048 merged commit bbe5d11 into apache:dev Nov 27, 2023
@Hisoka-X Hisoka-X deleted the fix-savemode-not-close branch November 27, 2023 05:56
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants