Skip to content

Conversation

@mosence
Copy link
Contributor

@mosence mosence commented Oct 27, 2023

Purpose of this pull request

Base on PR #5560 add e2e test case.
Issues #5623 .

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@mosence mosence changed the title [Test][e2e] Jdbc test need some case checking data consistency. [Test][e2e] Jdbc test checking data consistency. Oct 27, 2023
@Hisoka-X
Copy link
Member

Please resolve conflict

@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch 2 times, most recently from 63b692c to 976c232 Compare October 30, 2023 01:37
@mosence
Copy link
Contributor Author

mosence commented Oct 30, 2023

Please resolve conflict

@Hisoka-X It's done.

Originally posted by @mosence in #5560 (comment)
I guess that@testcontainerswill be mutil thread for test. so more task running on sametime. The result will be all task result. So incompare` mehtod had unpredictable error occurred.
So the e2e test I will add in Issue #5623.

Or someone can solve this problem?
image
`

@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch 3 times, most recently from 47b596a to e6601e1 Compare October 30, 2023 03:34
@Hisoka-X
Copy link
Member

I did some updated. Let's waiting CI.

@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch 2 times, most recently from 62f87e2 to 6c497ef Compare October 31, 2023 02:39
@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch 9 times, most recently from f70030c to 41dcc98 Compare October 31, 2023 06:57
@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch 2 times, most recently from eef3873 to ecd7db1 Compare October 31, 2023 09:33
@mosence mosence force-pushed the add-jdbc-e2e-compare-data branch from ecd7db1 to a03f156 Compare October 31, 2023 09:43
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mosence ! Looking great now. Just one question.

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Nov 1, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mosence !

@hailin0 hailin0 merged commit d8d289b into apache:dev Nov 1, 2023
@mosence mosence deleted the add-jdbc-e2e-compare-data branch March 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants