Skip to content

[Fix][Rest-API] fix submit job api #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hisoka-X merged 3 commits into from
Oct 27, 2023
Merged

[Fix][Rest-API] fix submit job api #5702

Hisoka-X merged 3 commits into from
Oct 27, 2023

Conversation

@liunaijie
Copy link
Member

@liunaijie liunaijie commented Oct 25, 2023

Purpose of this pull request

close #5699

Does this PR introduce any user-facing change?

How was this patch tested?

use postman

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 25, 2023

Could you add a test case for this? Seem like this is a very important feature we shouldn't missed. It's weird we don't have a test case to cover it. cc @liugddx

@liunaijie
Copy link
Member Author

liunaijie commented Oct 25, 2023

Could you add a test case for this? Seem like this is a very important feature we shouldn't missed. It's weird we don't have a test case to cover it. cc @liugddx

reuse the RestApiIT, but change something.

  1. remove Common.setDeployMode before startup
    when start the st cluster with ./bin/seatunnel-cluster.sh -d command, the deployMode will be null, so delete this setup to keep consistency

  2. remove parameter as they are optional when submit job.
    when submit job i think they all should be null. when re-store job they need have value.

@liunaijie liunaijie force-pushed the api-fix branch 2 times, most recently from c3dec54 to 36f4cfd Compare October 25, 2023 09:50
ruanwenjun
ruanwenjun approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hisoka-X
Hisoka-X approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liunaijie for fix! BTW, the test case you added are very important!

@Hisoka-X Hisoka-X merged commit 9980aa4 into apache:dev Oct 27, 2023
This was referenced Oct 27, 2023
Closed
Closed
@QiuZiXian QiuZiXian mentioned this pull request Oct 30, 2023
Closed
3 tasks
@liunaijie liunaijie deleted the api-fix branch October 30, 2023 13:15
@liunaijie liunaijie mentioned this pull request Dec 11, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liugddx liugddx liugddx left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved bug reviewed Zeta Rest API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Rest-API] submit job api has some issue

4 participants

@liunaijie @Hisoka-X @ruanwenjun @liugddx