-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Improve] Mark SeaTunnelPluginLifeCycle as deprecated
#5625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should remove it in 2.3.6, should not earlier than 2.3.6. We should leave time to developer which had customed their own plugin. But it depends on our progress on implement Factory SPI. |
| * @deprecated SeaTunnel will not invoke prepare when init plugin, instead by {@link | ||
| * org.apache.seatunnel.api.table.factory.Factory} | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these APIs be marked @deprecated?
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L58
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L65
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java#L42
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java#L49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. But https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L65 doesn't deprecated. Because we don't have a replacement yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it will be deprecated in the future
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
This PR mark
SeaTunnelPluginLifeCycleas deprecated. Prepare to remove it.Does this PR introduce any user-facing change?
No
How was this patch tested?
unnecessary
Check list
New License Guide
release-note.