Skip to content

Conversation

@happyboy1024
Copy link
Contributor

#5352
Because the try-with-resource syntax sugar is used, the connection is closed early during the checkpoint trigger phase, resulting in subsequent data writes failing

Purpose of this pull request

Check list

@happyboy1024 happyboy1024 changed the title Fix clickhouse sink flush bug [Bugfix][Clickhouse] Fix clickhouse sink flush bug Sep 8, 2023
@Carl-Zhou-CN
Copy link
Member

Yeah, you're right

@Carl-Zhou-CN
Copy link
Member

@Hisoka-X PTAL

@Hisoka-X
Copy link
Member

Thanks for the fix! Do you know which PR bring this bug?

@Carl-Zhou-CN
Copy link
Member

Thanks for the fix! Do you know which PR bring this bug?

#4999

@Carl-Zhou-CN
Copy link
Member

@Hisoka-X I'm sorry. It's because I ignored the grammar candy

@Hisoka-X
Copy link
Member

@Hisoka-X I'm sorry. It's because I ignored the grammar candy

never mind, I just want to know why it passed ci.

@liugddx liugddx merged commit cef03f6 into apache:dev Sep 12, 2023
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
* [Bug][connector-cdc-mysql] mysql connections and memory of jvm increased abnormally (apache#5008)

* [bugfix][connector-cdc-mysql] reset the listener of binaryLogClient before fetch task start (apache#5008)

* [Bugfix][Clickhouse] fix when the checkpoint triggers flush, the connection is closed, causing subsequent data writing to fail

---------

Co-authored-by: dengjunjie <[email protected]>
@happyboy1024 happyboy1024 deleted the fix-clickhouse-sink-flush-bug branch November 29, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants