Merged
Conversation
Contributor
Author
|
add rocketmq-streams-channel-rocketmq, rocketmq-streams-serviceloader, rocketmq-streams-window modules |
odbozhou
reviewed
Aug 2, 2021
Contributor
odbozhou
left a comment
There was a problem hiding this comment.
Please do not submit the target files generated by the compilation, such as .class and .jar files
| @@ -0,0 +1,74 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
iml files should not be submitted
Contributor
There was a problem hiding this comment.
Please clean up all iml files
Contributor
Author
There was a problem hiding this comment.
I have cleaned up the .class, .jar and .iml files, please confirm it, thks
odbozhou
approved these changes
Aug 2, 2021
RongtongJin
approved these changes
Aug 2, 2021
odbozhou
pushed a commit
to odbozhou/rocketmq-streams
that referenced
this pull request
Aug 10, 2021
merge to main branch
duhenglucky
pushed a commit
that referenced
this pull request
May 5, 2022
ni-ze
pushed a commit
to ni-ze/rocketmq-streams
that referenced
this pull request
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge to main branch