[ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug#173
Merged
ni-ze merged 4 commits intoapache:mainfrom Jun 28, 2022
Merged
Conversation
Contributor
Author
|
#174 fix incompatible types bug |
hyl-xidian
changed the title
ni-ze
reviewed
Jun 27, 2022
| @Override | ||
| public java.sql.Date getSqlDate(String key) { | ||
| return super.getSqlDate(key); | ||
| return (java.sql.Date) super.getSqlDate(key); |
Contributor
There was a problem hiding this comment.
It is cause by update fastjson version, and I fixed it by changed the return type.
Contributor
Contributor
|
@hyl-xidian can you remove the fix bug part? The others looks fine to me. |
Contributor
Author
@ni-ze Got it, I have removed the fix bug part. |
ni-ze
added a commit
to ni-ze/rocketmq-streams
that referenced
this pull request
Oct 7, 2022
[ISSUE apache#172][ISSUE apache#174]Modify the File Source Example; Update README; Fix incompatible types bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a filter usage example and modify the document.