Skip to content

[ISSUE #289] Use the default instance name when using acl#290

Merged
liuruiyiyang merged 2 commits intoapache:masterfrom
RongtongJin:not_set_instance_name
Aug 12, 2020
Merged

[ISSUE #289] Use the default instance name when using acl#290
liuruiyiyang merged 2 commits intoapache:masterfrom
RongtongJin:not_set_instance_name

Conversation

@RongtongJin
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Use the default instance name when using acl

Brief changelog

Use the default instance name when using acl

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin added this to the 2.1.2 milestone Aug 12, 2020
@liuruiyiyang liuruiyiyang self-requested a review August 12, 2020 02:14
@liuruiyiyang liuruiyiyang merged commit 8f24a5c into apache:master Aug 12, 2020
@RongtongJin RongtongJin linked an issue Aug 12, 2020 that may be closed by this pull request
@liuruiyiyang liuruiyiyang changed the title [ISSUE# 289] Use the default instance name when using acl [ISSUE #289] Use the default instance name when using acl Aug 12, 2020
@RongtongJin RongtongJin added this to the 2.2.0 milestone Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use default instance name when using ACL

2 participants