Skip to content

feat(callback): use start pointer to manager callbacks #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShannonDing merged 1 commit into from
Jan 15, 2020
Merged

feat(callback): use start pointer to manager callbacks #232

ShannonDing merged 1 commit into from
Jan 15, 2020

Conversation

@ShannonDing
Copy link
Member

@ShannonDing ShannonDing commented Jan 15, 2020

What is the purpose of the change

feat(callback): use start pointer to manager callbacks

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 15, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 15, 2020
@ShannonDing ShannonDing requested a review from jonnxu January 15, 2020 06:25
@ShannonDing ShannonDing merged commit f968f57 into apache:master Jan 15, 2020
@ifplusor
Copy link
Contributor

ifplusor commented Jan 15, 2020 •
edited
Loading

I think use unique_ptr is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnxu jonnxu Awaiting requested review from jonnxu

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.2.5

Development

Successfully merging this pull request may close these issues.

2 participants

@ShannonDing @ifplusor