Support BouncyCastle FIPS provider #6588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
changed the title
Member
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
tuteng
approved these changes
Mar 28, 2020
Member
|
@sijie @codelipenghui PTAL |
sijie
approved these changes
Mar 28, 2020
|
can we get maven relase of the same @jiazhai, so that we can consume into our projects? |
Member
|
It will be included in 2.5.1 release, which is planned to release this week. |
|
we need to test this as soon as possible, is there any intermitent bits kind of beta which can be refered for testing the changes? |
Member
|
@kemburi : you can use our weekly build: https://github.com/streamnative/pulsar/releases/tag/v2.6.0-347d3851b You can reference the build jar here: Use the version |
1 task
1 task
tuteng
pushed a commit
that referenced
this pull request
Apr 6, 2020
### Motivation Try to make user able to use both "org.bouncycastle.jce.provider.BouncyCastleProvider" and "org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider". Current code, bouncycastle (bc) jars are used in both broker and client, and are tied strongly in both broker and client. We need to make it easy config. This change try to split bc and module that depends on it. Then user could freely include/exclude it. ### Changes - build a shaded jar for bouncycastle non-fips version. other module depends on this module. - build nar for both fips and non-fips version of bouncycastle, user could able to load bouncycastle by these 2 nar. - split MessageCrypto out from client and made it an individual module. so client is able to exclude bouncycastle. - Add 2 test examples: 1, exclude bc-non-fips version, and include bc-fips version; 2, exclude bc-non-fips version and load bc-fips version by nar. (cherry picked from commit 181e5e7)
tuteng
pushed a commit
that referenced
this pull request
Apr 13, 2020
### Motivation Try to make user able to use both "org.bouncycastle.jce.provider.BouncyCastleProvider" and "org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider". Current code, bouncycastle (bc) jars are used in both broker and client, and are tied strongly in both broker and client. We need to make it easy config. This change try to split bc and module that depends on it. Then user could freely include/exclude it. ### Changes - build a shaded jar for bouncycastle non-fips version. other module depends on this module. - build nar for both fips and non-fips version of bouncycastle, user could able to load bouncycastle by these 2 nar. - split MessageCrypto out from client and made it an individual module. so client is able to exclude bouncycastle. - Add 2 test examples: 1, exclude bc-non-fips version, and include bc-fips version; 2, exclude bc-non-fips version and load bc-fips version by nar. (cherry picked from commit 181e5e7)
jiazhai
added a commit
to jiazhai/pulsar
that referenced
this pull request
May 18, 2020
### Motivation Try to make user able to use both "org.bouncycastle.jce.provider.BouncyCastleProvider" and "org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider". Current code, bouncycastle (bc) jars are used in both broker and client, and are tied strongly in both broker and client. We need to make it easy config. This change try to split bc and module that depends on it. Then user could freely include/exclude it. ### Changes - build a shaded jar for bouncycastle non-fips version. other module depends on this module. - build nar for both fips and non-fips version of bouncycastle, user could able to load bouncycastle by these 2 nar. - split MessageCrypto out from client and made it an individual module. so client is able to exclude bouncycastle. - Add 2 test examples: 1, exclude bc-non-fips version, and include bc-fips version; 2, exclude bc-non-fips version and load bc-fips version by nar. (cherry picked from commit 181e5e7)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Try to make user able to use both "org.bouncycastle.jce.provider.BouncyCastleProvider" and "org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider". Current code, bouncycastle (bc) jars are used in both broker and client, and are tied strongly in both broker and client. We need to make it easy config. This change try to split bc and module that depends on it. Then user could freely include/exclude it. ### Changes - build a shaded jar for bouncycastle non-fips version. other module depends on this module. - build nar for both fips and non-fips version of bouncycastle, user could able to load bouncycastle by these 2 nar. - split MessageCrypto out from client and made it an individual module. so client is able to exclude bouncycastle. - Add 2 test examples: 1, exclude bc-non-fips version, and include bc-fips version; 2, exclude bc-non-fips version and load bc-fips version by nar.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Try to make user able to use both "org.bouncycastle.jce.provider.BouncyCastleProvider" and "org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider".
Current code, bouncycastle (bc) jars are used in both broker and client, and are tied strongly in both broker and client. We need to make it easy config. This change try to split bc and module that depends on it. Then user could freely include/exclude it.
Changes