Skip to content

Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wolfstudy merged 1 commit into from
Nov 25, 2019
Merged

Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed #5733

wolfstudy merged 1 commit into from
Nov 25, 2019

Conversation

@wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Nov 25, 2019 •
edited
Loading

Motivation

Revert the #5603 from branch-2.4.

This pr does not seem to be merged to branch-2.4, because getDefaultBackoffIntervalNanos, useUserConfiguredIntervals is not defined in branch-2.4.

@wolfstudy wolfstudy requested a review from sijie November 25, 2019 02:46
@wolfstudy wolfstudy self-assigned this Nov 25, 2019
@wolfstudy wolfstudy requested a review from jiazhai November 25, 2019 03:48
@wolfstudy wolfstudy changed the title Revert "[Issue 5597][pulsar-client-java] retry when getPartitionedTop… Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed Nov 25, 2019
@sijie
Copy link
Member

sijie commented Nov 25, 2019

@wolfstudy thank you for point this out.

Can you also send out a pull request to apply #5603 to master?

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 25, 2019

Can you also send out a pull request to apply #5603 to master?

Sure

@sijie
Copy link
Member

sijie commented Nov 25, 2019

run cpp tests
run integration tests

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 25, 2019

run cpp tests

1 similar comment
@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 25, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Nov 25, 2019

I don't think we are able to pass the c++ test because of the way how the tests setup. The tests don't run well on branches. If this is a revert change, we can just merge it. We should figure out a robust plan to test branches.

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 25, 2019

I don't think we are able to pass the c++ test because of the way how the tests setup. The tests don't run well on branches. If this is a revert change, we can just merge it. We should figure out a robust plan to test branches.

Thanks sijie, i will merge this pull request and open issue track the test in branch.

@wolfstudy wolfstudy mentioned this pull request Nov 25, 2019
Closed
@wolfstudy wolfstudy merged commit 811dd45 into branch-2.4 Nov 25, 2019
@sijie sijie deleted the revert-5603-branch-2.4 branch December 9, 2019 07:23
@sijie sijie mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@wolfstudy wolfstudy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolfstudy @sijie