Make Function Authentication Provider pluggable #5404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@addisonj please also take a look |
Contributor
Author
|
rerun integration tests |
1 similar comment
Contributor
Author
|
rerun integration tests |
Contributor
Author
|
rerun java8 tests |
Contributor
Author
|
rerun integration tests |
2 similar comments
Contributor
Author
|
rerun integration tests |
Contributor
Author
|
rerun integration tests |
merlimat
approved these changes
Oct 23, 2019
1 task
jerrypeng
added a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Dec 17, 2019
* Make Function Authentication Provider pluaggable * add config comments * cleaning up * cleaning up * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The FunctionAuthProvider is an interface responsible for distributing authentication data to functions. Currently the implementation used is hard coded and not pluggable.
Modifications
Make FunctionAuthProvider pluggable so uses can choose implementations