-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[functions] Distribute the CA for KubernetesSecretsTokenAuthProvider #5398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added a follow up issue for docs: #5399 |
|
This conflicts with #5400, will need rebased if that is merged first |
jerrypeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@addisonj thanks for contributing this! I am also in process to make FunctionAuthProvider pluggable. Currently which one that is used is hard coded
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
Currently, if a user has TLS enabled and is using a custom CA that isn't baked into the image, when the functions worker starts, it won't have the CA in order to validate the cert presented by the broker. This adds support to have the `KubernetesSecretsTokenAuthProvider` also distribute the CA via the same kubernetes secret used for the token.
d06df2a to
60e2847
Compare
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
…apache#5398) Currently, if a user has TLS enabled and is using a custom CA that isn't baked into the image, when the functions worker starts, it won't have the CA in order to validate the cert presented by the broker. This adds support to have the `KubernetesSecretsTokenAuthProvider` also distribute the CA via the same kubernetes secret used for the token.
Motivation
Currently, if a user has TLS enabled and is using a custom CA that isn't
baked into the image, when the functions worker starts, it won't have
the CA in order to validate the cert presented by the broker.
Modifications
This adds support to have the
KubernetesSecretsTokenAuthProvideralso distribute the CA via the same kubernetes secret used for the
token.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation