Skip to content

Conversation

@addisonj
Copy link
Contributor

Motivation

Currently, if a user has TLS enabled and is using a custom CA that isn't
baked into the image, when the functions worker starts, it won't have
the CA in order to validate the cert presented by the broker.

Modifications

This adds support to have the KubernetesSecretsTokenAuthProvider
also distribute the CA via the same kubernetes secret used for the
token.

Verifying this change

  • [x ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added tests to ensure that the code paths work with and without a CA
  • Added tests to ensure that the filename returned is as expected

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented, but the KubernetesSecretsTokenAuthProvider is missing docs complete
  • If a feature is not applicable for documentation, explain why? It does need docs, but the functionality as a whole is missing docs
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@addisonj
Copy link
Contributor Author

Added a follow up issue for docs: #5399

@addisonj
Copy link
Contributor Author

This conflicts with #5400, will need rebased if that is merged first

Copy link
Contributor

@jerrypeng jerrypeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addisonj thanks for contributing this! I am also in process to make FunctionAuthProvider pluggable. Currently which one that is used is hard coded

@addisonj
Copy link
Contributor Author

rerun java8 tests
rerun integration tests

1 similar comment
@addisonj
Copy link
Contributor Author

rerun java8 tests
rerun integration tests

Currently, if a user has TLS enabled and is using a custom CA that isn't
baked into the image, when the functions worker starts, it won't have
the CA in order to validate the cert presented by the broker.

This adds support to have  the `KubernetesSecretsTokenAuthProvider`
also distribute the CA via the same kubernetes secret used for the
token.
@addisonj
Copy link
Contributor Author

rerun java8 tests

1 similar comment
@addisonj
Copy link
Contributor Author

rerun java8 tests

@sijie sijie added this to the 2.5.0 milestone Oct 28, 2019
@sijie sijie merged commit 28b0c3a into apache:master Oct 28, 2019
jerrypeng pushed a commit to jerrypeng/incubator-pulsar that referenced this pull request Dec 17, 2019
…apache#5398)

Currently, if a user has TLS enabled and is using a custom CA that isn't
baked into the image, when the functions worker starts, it won't have
the CA in order to validate the cert presented by the broker.

This adds support to have  the `KubernetesSecretsTokenAuthProvider`
also distribute the CA via the same kubernetes secret used for the
token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants