Skip to content

Increase the retries count for PulsarFunctionStateTest #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merlimat merged 6 commits into from
Feb 12, 2020
Merged

Increase the retries count for PulsarFunctionStateTest #5328

merlimat merged 6 commits into from
Feb 12, 2020

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 7, 2019

Motivation

The test has been intermittently failing:

2019-10-07\T\20:09:37.235 [ERROR] testPulsarFunctionState(org.apache.pulsar.functions.worker.PulsarFunctionStateTest)  Time elapsed: 2.607 s  <<< FAILURE!
java.lang.AssertionError: expected [1] but found [0]
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.failNotEquals(Assert.java:776)
	at org.testng.Assert.assertEqualsImpl(Assert.java:137)
	at org.testng.Assert.assertEquals(Assert.java:118)
	at org.testng.Assert.assertEquals(Assert.java:652)
	at org.testng.Assert.assertEquals(Assert.java:662)
	at org.apache.pulsar.functions.worker.PulsarFunctionStateTest.testPulsarFunctionState(PulsarFunctionStateTest.java:316)

Increasing the number of retries, since this seems related to slowness in Jenkins.

@merlimat merlimat added this to the 2.5.0 milestone Oct 7, 2019
@merlimat merlimat self-assigned this Oct 7, 2019
@jerrypeng
Copy link
Contributor

jerrypeng commented Oct 8, 2019

rerun integration tests
rerun java8 tests

@codelipenghui
Copy link
Contributor

codelipenghui commented Oct 10, 2019

run java8 tests

@merlimat
Copy link
Contributor Author

merlimat commented Oct 24, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Oct 25, 2019

run java8 tests
run integration tests

@aahmed-se
Copy link
Contributor

aahmed-se commented Oct 25, 2019

run java8 tests

1 similar comment
@sijie
Copy link
Member

sijie commented Nov 12, 2019

run java8 tests

@sijie sijie removed this from the 2.5.0 milestone Nov 25, 2019
@devinbost devinbost mentioned this pull request Feb 4, 2020
Closed
@merlimat merlimat merged commit 50d9352 into apache:master Feb 12, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@merlimat @huangdx0726
Increase the retries count for PulsarFunctionStateTest (apache#5328)
d66f547 
* Increase the retries count for PulsarFunctionStateTest

* Increased retries in similar tests backoffs

* Fixed merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia rdhabalia approved these changes

@jerrypeng jerrypeng jerrypeng approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels

area/test type/flaky-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@merlimat @jerrypeng @codelipenghui @sijie @aahmed-se @rdhabalia