[cleanup] Convert 12 test classes to SharedPulsarBaseTest#25392
Merged
merlimat merged 4 commits intoapache:masterfrom Mar 24, 2026
Merged
[cleanup] Convert 12 test classes to SharedPulsarBaseTest#25392merlimat merged 4 commits intoapache:masterfrom
merlimat merged 4 commits intoapache:masterfrom
Conversation
ClientGetSchemaTest, ConsumerRedeliveryTest, DeadLetterTopicTest, DispatcherBlockConsumerTest, MaxUnackedMessagesTest, MessagePayloadProcessorTest, PatternMultiTopicsConsumerTest, ProducerCloseTest, ResourceGroupUsageAggregationTest, RGUsageMTAggrWaitForAllMsgsTest, TopicDoesNotExistsTest, UnloadSubscriptionTest
This test modifies broker-level settings (maxUnackedMessagesPerBroker, blockedDispatchers) that leak across retries in the shared cluster, causing "Run 1: PASS, Run 2: FAILURE".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25392 +/- ##
============================================
- Coverage 72.81% 72.73% -0.09%
+ Complexity 34347 34276 -71
============================================
Files 1954 1954
Lines 154878 154878
Branches 17742 17742
============================================
- Hits 112771 112645 -126
- Misses 33088 33178 +90
- Partials 9019 9055 +36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
BookieClientsStatsGeneratorTest, MessageIdTest, PerMessageUnAcknowledgedRedeliveryTest
lhotari
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProducerConsumerBase/BrokerTestBasetoSharedPulsarBaseTestClientGetSchemaTest,ConsumerRedeliveryTest,DeadLetterTopicTest,DispatcherBlockConsumerTest,MaxUnackedMessagesTest,MessagePayloadProcessorTest,PatternMultiTopicsConsumerTest,ProducerCloseTest,ResourceGroupUsageAggregationTest,RGUsageMTAggrWaitForAllMsgsTest,TopicDoesNotExistsTest,UnloadSubscriptionTestMessagePayloadProcessorTestsinceCustomBatchProducerwrites directly to managed ledger without producer name/sequence IDDocumentation
doc-not-neededMatching PR in forked repository
PR in forked repository:
The tests were verified with
invocationCount=100(96 tests total, 0 failures).