Skip to content

[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMap in Topic classes #23322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BewareMyPower merged 8 commits into from
Sep 21, 2024
Merged

[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMap in Topic classes #23322

BewareMyPower merged 8 commits into from
Sep 21, 2024

Conversation

@BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Sep 19, 2024 •
edited
Loading

Main Issue: #23215

Modifications

Apply the replacements for classes that implement org.apache.pulsar.broker.service.Topic interface.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: BewareMyPower#36

@BewareMyPower BewareMyPower added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Sep 19, 2024
@BewareMyPower BewareMyPower added this to the 4.0.0 milestone Sep 19, 2024
@BewareMyPower BewareMyPower self-assigned this Sep 19, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 19, 2024
@BewareMyPower BewareMyPower mentioned this pull request Sep 19, 2024
Closed
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (bbc6224) to head (dbc8a65).
Report is 594 commits behind head on master.

Files with missing lines Patch % Lines
...sar/broker/service/persistent/PersistentTopic.java 72.00% 5 Missing and 2 partials ⚠️
...oker/service/nonpersistent/NonPersistentTopic.java 40.00% 3 Missing ⚠️
...rg/apache/pulsar/broker/service/BrokerService.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23322      +/-   ##
============================================
+ Coverage     73.57%   74.63%   +1.06%     
- Complexity    32624    33891    +1267     
============================================
  Files          1877     1936      +59     
  Lines        139502   145546    +6044     
  Branches      15299    15928     +629     
============================================
+ Hits         102638   108632    +5994     
+ Misses        28908    28608     -300     
- Partials       7956     8306     +350
Flag Coverage Δ
inttests 27.80% <15.78%> (+3.21%) ⬆️
systests 24.64% <10.52%> (+0.32%) ⬆️
unittests 74.00% <71.05%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java 69.64% <100.00%> (+4.19%) ⬆️
...rg/apache/pulsar/broker/service/AbstractTopic.java 87.84% <ø> (-0.14%) ⬇️
...n/java/org/apache/pulsar/broker/service/Topic.java 37.50% <ø> (+1.13%) ⬆️
.../persistent/ReplicatedSubscriptionsController.java 70.42% <100.00%> (-2.18%) ⬇️
...istent/ReplicatedSubscriptionsSnapshotBuilder.java 80.85% <100.00%> (-0.40%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 83.16% <50.00%> (+2.38%) ⬆️
...oker/service/nonpersistent/NonPersistentTopic.java 71.54% <40.00%> (+2.08%) ⬆️
...sar/broker/service/persistent/PersistentTopic.java 79.20% <72.00%> (+0.74%) ⬆️

... and 592 files with indirect coverage changes

@BewareMyPower BewareMyPower merged commit 1ce7855 into apache:master Sep 21, 2024
@Demogorgon314 Demogorgon314 mentioned this pull request Sep 29, 2024
Merged
4 tasks
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@BewareMyPower @hanmz
[improve][broker] Replace ConcurrentOpenHashMap with ConcurrentHashMa…
0360efa 
…p in Topic classes (apache#23322)
@BewareMyPower BewareMyPower deleted the bewaremypower/concurrent-openhashmap-topic branch June 20, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@eolivelli eolivelli Awaiting requested review from eolivelli

@nodece nodece Awaiting requested review from nodece

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@thetumbled thetumbled Awaiting requested review from thetumbled

Assignees

@BewareMyPower BewareMyPower

Labels

area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@BewareMyPower @codecov-commenter @RobertIndie @Demogorgon314