[fix] [broker] fix replicated namespaces filter in filterAndUnloadMatchedNamespaceAsync #23100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
lhotari
reviewed
Jul 30, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Jul 30, 2024
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
LGTM. The concurrency limiting solution will be needed to prevent issues for clusters with a lot of tenants and namespaces.
Member
|
A test case would be needed. optimally a test that reproduces the original issue so that we can see that the changes fix it. |
Member
|
thanks for the contribution @iosdev747 , great work! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23100 +/- ##
============================================
- Coverage 73.57% 73.45% -0.13%
- Complexity 32624 33540 +916
============================================
Files 1877 1919 +42
Lines 139502 144107 +4605
Branches 15299 15747 +448
============================================
+ Hits 102638 105851 +3213
- Misses 28908 30152 +1244
- Partials 7956 8104 +148
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
requested review from
Technoboy-,
codelipenghui,
mattisonchao and
poorbarcode
Technoboy-
pushed a commit
that referenced
this pull request
Aug 1, 2024
…chedNamespaceAsync (#23100) Co-authored-by: Lari Hotari <[email protected]>
lhotari
added a commit
that referenced
this pull request
Aug 6, 2024
…chedNamespaceAsync (#23100) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 5aa5e7d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 8, 2024
…chedNamespaceAsync (apache#23100) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 6c01bb0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 12, 2024
…chedNamespaceAsync (apache#23100) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 6c01bb0)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…chedNamespaceAsync (apache#23100) Co-authored-by: Lari Hotari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #23092
Motivation
Problem is namespace unload operation happens on all the namespaces that matches the policy regex. Check should be done only on namespaces in current cluster.
Modifications
Fix namespace filter so only namespaces in current cluster should be used for unload operation.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: iosdev747#2