[improve][broker] don't do load shedding when metadata service not available #23040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
codelipenghui,
eolivelli,
gaoran10,
lhotari,
liangyepianzhou and
poorbarcode
congbobo184
changed the title
poorbarcode
approved these changes
Jul 17, 2024
poorbarcode
reviewed
Jul 17, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java
Show resolved
Hide resolved
…/metadata_service_not_available_dont_do_load_shedding
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23040 +/- ##
============================================
- Coverage 73.57% 73.48% -0.10%
- Complexity 32624 33196 +572
============================================
Files 1877 1915 +38
Lines 139502 143948 +4446
Branches 15299 15727 +428
============================================
+ Hits 102638 105773 +3135
- Misses 28908 30071 +1163
- Partials 7956 8104 +148
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Jul 19, 2024
congbobo184
force-pushed
the
improve/loadbalance/metadata_service_not_available_dont_do_load_shedding
branch
from
78b0a99 to
243aa81
Compare
…/metadata_service_not_available_dont_do_load_shedding
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ailable (apache#23040) ### Motivation don't do load shedding when metadata service not available. if unload bundle when metadata service not available, these topics which in this bundle can't recover the current ledger and send read again ### Modifications 1. check metadata service state when do load shedding task 2. do not interrupt the task are doing in the same time
Merged
4 tasks
congbobo184
pushed a commit
that referenced
this pull request
Oct 14, 2025
…vice is available again (#24838) Motivation After PR: #23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again. Modifications Ensure LoadSheddingTask is scheduled after metadata service is available again by moving the isMetadataServiceAvailable check to the try block.
lhotari
pushed a commit
that referenced
this pull request
Oct 14, 2025
…vice is available again (#24838) Motivation After PR: #23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again. Modifications Ensure LoadSheddingTask is scheduled after metadata service is available again by moving the isMetadataServiceAvailable check to the try block. (cherry picked from commit 461ffd8)
lhotari
pushed a commit
that referenced
this pull request
Oct 14, 2025
…vice is available again (#24838) Motivation After PR: #23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again. Modifications Ensure LoadSheddingTask is scheduled after metadata service is available again by moving the isMetadataServiceAvailable check to the try block. (cherry picked from commit 461ffd8)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…vice is available again (apache#24838) Motivation After PR: apache#23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again. Modifications Ensure LoadSheddingTask is scheduled after metadata service is available again by moving the isMetadataServiceAvailable check to the try block. (cherry picked from commit 461ffd8) (cherry picked from commit 49d4257)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…vice is available again (apache#24838) Motivation After PR: apache#23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again. Modifications Ensure LoadSheddingTask is scheduled after metadata service is available again by moving the isMetadataServiceAvailable check to the try block. (cherry picked from commit 461ffd8) (cherry picked from commit 49d4257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
don't do load shedding when metadata service not available.
if unload bundle when metadata service not available, these topics which in this bundle can't recover the current ledger and send read again
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: