[improve] [pip] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.#22940
Merged
BewareMyPower merged 8 commits intoapache:masterfrom Aug 13, 2024
Conversation
Technoboy-
reviewed
Jun 20, 2024
Member
|
+1 |
lhotari
reviewed
Jun 25, 2024
lhotari
reviewed
Jun 27, 2024
Member
Author
|
@lhotari Do you have any suggestions? |
Member
Author
|
@lhotari @Technoboy- Could you please vote here? Thank you. |
Member
Author
|
The vote has passed with 3 binding +1s. https://lists.apache.org/thread/t0olt3722j17gjtdxqqsl3cpy104ogpr |
Member
Author
|
@RobertIndie @BewareMyPower Could you please approve and merge this PR? |
BewareMyPower
approved these changes
Aug 13, 2024
15 tasks
1 task
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…pache.pulsar.client.impl.SendCallback.sendComplete. (apache#22940)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…pache.pulsar.client.impl.SendCallback.sendComplete. (apache#22940)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As introduced in PIP-264, Pulsar has been fully integrated into the
OpenTelemetrysystem, which defines some metric specifications for messaging systems.In the current Pulsar client code, it is not possible to obtain the number of messages sent in batches(as well as some other sending data), making it impossible to implement
messaging.publish.messagesmetric.In the
opentelemetry-java-instrumentationcode, theorg.apache.pulsar.client.impl.SendCallbackinterface is used to instrument data points. For specific implementation details, we can refer to this.In the current situation,
org.apache.pulsar.client.impl.ProducerImpldoes not provide a public method to obtain thenumMessagesInBatch.So, we can add some of
org.apache.pulsar.client.impl.ProducerImpl.OpSendMsg's key data into theorg.apache.pulsar.client.impl.SendCallback.sendCompletemethod.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: