[improve][broker] Deprecate unused enableNamespaceIsolationUpdateOnTime config #22449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me config ### Motivation apache#8976 introduced an `enableNamespaceIsolationUpdateOnTime` config, which is useless after apache#15527. This config actually does not make sense because it should always be true, while it's false by default just to keep the meaningless compatibility. ### Motivation Deprecate this config and strength the `brokerNamespaceIsolationPoliciesUpdateOnTime` test.
BewareMyPower
requested review from
Demogorgon314,
Technoboy-,
codelipenghui,
lhotari and
mattisonchao
github-actions
bot
added
the
doc
dao-jun
approved these changes
Apr 7, 2024
Technoboy-
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#8976 introduced an
enableNamespaceIsolationUpdateOnTimeconfig, which is useless after #15527. This config actually does not make sense because it should always be true, while it's false by default just to keep the meaningless compatibility.Motivation
Deprecate this config and strength the
brokerNamespaceIsolationPoliciesUpdateOnTimetest.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: