[improve][misc] Register Jackson Java 8 support modules by default #19161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cbornet
reviewed
Jan 10, 2023
pulsar-common/src/main/java/org/apache/pulsar/common/util/ObjectMapperFactory.java
Outdated
Show resolved
Hide resolved
nicoloboschi
approved these changes
Jan 11, 2023
cbornet
approved these changes
Jan 12, 2023
lhotari
force-pushed
the
lh-add-jackson-java8-modules
branch
from
4ddcb22 to
ea891ce
Compare
lhotari
changed the title
Member
Author
|
Since a PIP was requested, I have created #19243 which is already in voting since there was already a discussion. |
lhotari
force-pushed
the
lh-add-jackson-java8-modules
branch
from
ea891ce to
4a768ad
Compare
…Pulsar - Jackson contains Java 8 support modules that haven't been added and registered in Pulsar. - more information about modules: https://github.com/FasterXML/jackson-modules-java8 - Add Parameter names, Java 8 Date/time and Java 8 Datatypes modules and register them by default
lhotari
force-pushed
the
lh-add-jackson-java8-modules
branch
from
4a768ad to
582d5dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #19161 +/- ##
============================================
- Coverage 63.54% 62.67% -0.87%
- Complexity 3615 25488 +21873
============================================
Files 1895 1818 -77
Lines 137475 133061 -4414
Branches 15091 14637 -454
============================================
- Hits 87355 83395 -3960
+ Misses 42240 41963 -277
+ Partials 7880 7703 -177
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change applies to Jackson usage on the server side (Broker, Pulsar Functions etc.) and on the client.
Modifications
Additional context
dev mailing list thread: https://lists.apache.org/thread/9bxs90q0m5phhytz6480b6fcnfclxt3s
This PR depends on #19160 so that the properly configured ObjectMapper instances are used.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#125