[fix][broker] Fix NPE when updating topic properties #17352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please follow Pulsar Pull Request Naming Convention Guide: https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35 |
Flowermin
changed the title
Contributor
Author
Done |
merlimat
approved these changes
Aug 30, 2022
AnonHxy
approved these changes
Aug 31, 2022
AnonHxy
added
type/bug
nodece
approved these changes
Aug 31, 2022
Jason918
approved these changes
Aug 31, 2022
Contributor
|
Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @Flowermin |
Contributor
|
It' a fix for this PR #17238 (comment), we should also remove the label @Jason918 |
liangyepianzhou
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Apr 28, 2023
Co-authored-by: bjhuxiaohua <[email protected]>
liangyepianzhou
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
May 10, 2023
Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158)
liangyepianzhou
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Sep 27, 2023
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) (cherry picked from commit 6f8dbc7) * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) (cherry picked from commit 723ad75) * [fix][broker] Fix NPE when update topic properties. ### Motivation In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`. ### Modifications Add an NPE check. (cherry picked from commit 0b02321) * remove release profile * import * Revert "remove release profile" This reverts commit 6bec650. --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
liangyepianzhou
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Sep 27, 2023
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) (cherry picked from commit 6f8dbc7) * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) (cherry picked from commit 723ad75) * [fix][broker] Fix NPE when update topic properties. ### Motivation In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`. ### Modifications Add an NPE check. (cherry picked from commit 0b02321) * remove release profile * import * Revert "remove release profile" This reverts commit 6bec650. --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Nov 27, 2023
Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Nov 27, 2023
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 15, 2024
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 15, 2024
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
May 11, 2024
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NPE occurs if
p.propertiesisnullwhen updating topic's properties in #17238 .Documentation
doc-not-needed