Skip to content

[improve][broker][PIP-149]make deleteTopic method async #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jason918 merged 2 commits into from
Jun 28, 2022
Merged

[improve][broker][PIP-149]make deleteTopic method async #16232

Jason918 merged 2 commits into from
Jun 28, 2022

Conversation

@HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Jun 27, 2022

Master Issue: #14013

Motivation

See #14365

Verifying this change

Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 27, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jun 27, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Jun 27, 2022
@HQebupt
Copy link
Contributor Author

HQebupt commented Jun 27, 2022

/pulsarbot run-failure-checks

@HQebupt HQebupt force-pushed the asyncDeleteTopic branch from 6985c18 to c8ecf13 Compare June 27, 2022 07:23
@HQebupt
Copy link
Contributor Author

HQebupt commented Jun 27, 2022

/pulsarbot rerun-failure-checks

1 similar comment
@HQebupt
Copy link
Contributor Author

HQebupt commented Jun 27, 2022

/pulsarbot rerun-failure-checks

@HQebupt HQebupt force-pushed the asyncDeleteTopic branch from c8ecf13 to 77b693a Compare June 27, 2022 10:16
@HQebupt HQebupt force-pushed the asyncDeleteTopic branch from 77b693a to 2cd50d6 Compare June 27, 2022 13:41
@Jason918 Jason918 merged commit 97e278b into apache:master Jun 28, 2022
@RobertIndie RobertIndie mentioned this pull request Jun 29, 2022
Closed
1 task
@gaozhangmin gaozhangmin mentioned this pull request Aug 22, 2022
Closed
5 tasks
@tisonkun tisonkun mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@gaozhangmin gaozhangmin gaozhangmin approved these changes

Assignees

@HQebupt HQebupt

Labels

area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@HQebupt @Jason918 @Technoboy- @gaozhangmin