Skip to content

[improve][broker][PIP-149]make terminate method async #16227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 2 commits into from
Jun 27, 2022
Merged

[improve][broker][PIP-149]make terminate method async #16227

Technoboy- merged 2 commits into from
Jun 27, 2022

Conversation

@HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Jun 26, 2022

Master Issue: #14013

Motivation

See #14365

Verifying this change

Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 26, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Jun 27, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jun 27, 2022
@HQebupt
validateTopicOperationAsync and validateTopicOwnershipAsync should be…
dca2ae4 
… preceded the getPartitionedTopicMetadataAsync
@HQebupt
Copy link
Contributor Author

HQebupt commented Jun 27, 2022

/pulsarbot rerun-failure-checks

@gaozhangmin
Copy link
Contributor

gaozhangmin commented Jun 27, 2022

@Technoboy- PTAL again, changes made.

@gaozhangmin gaozhangmin requested a review from Technoboy- June 27, 2022 10:25
@Technoboy- Technoboy- merged commit ebcc47e into apache:master Jun 27, 2022
@RobertIndie RobertIndie mentioned this pull request Jun 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

No one assigned

Labels

area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@HQebupt @gaozhangmin @Technoboy-