Skip to content

Conversation

@tjiuming
Copy link
Contributor

@tjiuming tjiuming commented May 25, 2022

Motivation

doc for #15674

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-not-needed Your PR changes do not impact docs and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels May 25, 2022
@github-actions
Copy link

@tjiuming:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-label-missing doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-not-needed Your PR changes do not impact docs labels May 26, 2022
@Anonymitaet Anonymitaet mentioned this pull request May 26, 2022
4 tasks
Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momo-jun
Copy link
Contributor

Ping @Anonymitaet.

@tjiuming
Copy link
Contributor Author

tjiuming commented Jul 2, 2022

@Anonymitaet Please help merge the PR

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-complete Your PR changes impact docs and the related docs have been already added. doc-label-missing labels Jul 4, 2022
@Anonymitaet
Copy link
Member

These checks are skipped, can I merge this PR? @tjiuming
image

@tjiuming
Copy link
Contributor Author

tjiuming commented Jul 4, 2022

These checks are skipped, can I merge this PR? @tjiuming image

All the required CI checks passed, I believe it's able to merge

@Anonymitaet Anonymitaet merged commit b0c9cc1 into apache:master Jul 4, 2022
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Jul 4, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Jul 5, 2022
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
@tjiuming tjiuming deleted the dev/message_ack_rate_doc branch August 14, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants