Skip to content

Conversation

@maxsxu
Copy link
Contributor

@maxsxu maxsxu commented May 25, 2022

Fixes #15732

Motivation

Rename doc label.

Modifications

  • no-need-doc -> doc-not-needed
  • doc-added -> doc-complete

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 25, 2022
@Anonymitaet Anonymitaet requested a review from urfreespace May 26, 2022 02:16
@Anonymitaet Anonymitaet merged commit 34673dd into apache:master May 26, 2022
@Anonymitaet Anonymitaet changed the title Rename doc label in PR template [fix][workflow] Rename doc label in PR template May 26, 2022
@Anonymitaet
Copy link
Member

@maxsxu I've renamed your PR based on Pulsar PR Naming Convention Guide, please follow the rules, thanks

@Anonymitaet Anonymitaet added this to the 2.11.0 milestone May 26, 2022
@maxsxu maxsxu deleted the feat/rename-doc-label branch August 24, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename doc label (Bot)

2 participants